This repository was archived by the owner on Jan 11, 2022. It is now read-only.
auth: create_token fn to create token for gistey#45
Open
meetmangukiya wants to merge 1 commit intomasterfrom
Open
auth: create_token fn to create token for gistey#45meetmangukiya wants to merge 1 commit intomasterfrom
meetmangukiya wants to merge 1 commit intomasterfrom
Conversation
meetmangukiya
force-pushed
the
meet/gh-token
branch
from
8ab21eb to
0f726e3
Compare
meetmangukiya
commented
Dec 22, 2016
gistey/auth.py
Outdated
| headers={"X-GitHub-OTP": otp}) | ||
|
|
||
| return rq | ||
| #TODO Returns 404 =/ Confusing |
meetmangukiya
commented
Dec 22, 2016
| return partial(func, auth=(username, password)) | ||
|
|
||
|
|
||
| @authorize |
Owner
Author
There was a problem hiding this comment.
There seems to be a problem in making authorize function as the decorator.
Because currently, the decorator right away asks for username and password instead of asking at function call.
meetmangukiya
commented
Dec 26, 2016
|
|
||
| if "X-GitHub-OTP" in rq.headers: | ||
| otp = input("Enter 2FA code: ") | ||
| rq = requests.put(end + "authorizations/", params=params, auth=auth, |
| end = "https://api.github.com/" | ||
|
|
||
|
|
||
| def authorize(func): |
Owner
Author
There was a problem hiding this comment.
Completely remove it for now, if needed we will introduce in future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
This change is